add support for XCP-ng 7/8 to create it's heartbeat LVM properly#4109
Merged
yadvr merged 2 commits intoapache:masterfrom Jun 11, 2020
Merged
add support for XCP-ng 7/8 to create it's heartbeat LVM properly#4109yadvr merged 2 commits intoapache:masterfrom
yadvr merged 2 commits intoapache:masterfrom
Conversation
Member
|
cc @shwstppr |
yadvr
approved these changes
May 29, 2020
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✔debian. JID-1276 |
Member
|
@shwstppr can you review this? |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✖debian. JID-1304 |
shwstppr
approved these changes
Jun 9, 2020
|
Packaging result: ✔centos7 ✔debian. JID-1328 |
Contributor
|
Packaging OK! |
Member
|
Trillian env runs using NFS, this case won't get tested by default. Travis passed https://travis-ci.org/github/apache/cloudstack/builds/696396726 I'll merge based on this and that the author has provided information how this was tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
/opt/cloud/bin/setup_heartbeat_sr.shline 75 tests for “XenServer release 7.” in/etc/redhat-releasewhich contains “XCP-ng release 8.0.0 (xenenterprise)” in my case so thelvcreatestatement doesn’t contain the required optionsFixes: #3281
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Adding an iSCSI endpoint now succeeds with XCP-ng 8.0.0. I've left the previous XenServer logic alone just added the XCP-ng test case into the else block. This could definitely be fine tuned by someone who's more intimate with these scripts but I just wanted the issue fixed without interfering in the logic.